Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14920 Counters tab display #376

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

dpanshug
Copy link
Collaborator

@dpanshug dpanshug commented Jul 3, 2023

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The counters tab does not get refresh when we create a new counter

@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

Screenshot 2023-07-04 at 10 07 10

@dpanshug
Copy link
Collaborator Author

dpanshug commented Jul 6, 2023

Creating the first counter and then fetching, the issue seems to be from the backend, discussed this with Pedro R. and created jira ISPN-15023.

@karesti
Copy link
Collaborator

karesti commented Jul 12, 2023

@dpanshug when I move to another page, the fetch works correctly when I come back to the cache manager page

@dpanshug dpanshug force-pushed the ISPN-14920-counters branch 2 times, most recently from b8efa07 to 21eddeb Compare July 12, 2023 11:02
@dpanshug
Copy link
Collaborator Author

dpanshug commented Jul 12, 2023

@dpanshug when I move to another page, the fetch works correctly when I come back to the cache manager page

@karesti Yes, the counter is fetched after reloading the page. When we create the very first counter on the server, it is not fetched. However, if we create and delete the first counter and then create another counter on the same server, the fetch operation works correctly.

The issue is with the very first counter on the server.

@karesti
Copy link
Collaborator

karesti commented Sep 21, 2023

Creating the first counter and then fetching, the issue seems to be from the backend, discussed this with Pedro R. and created jira ISPN-15023.

I fixed temporarly by calling twice when the result is empty

@@ -150,93 +150,95 @@ describe('Counters CRUD', () => {
cy.get("[aria-label='counters-table-label']").contains("td", "strong-5").should("not.exist");
});

it ('successfully filters counters', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyuk1986 the behaviour works, but this test stops because is unable to open "the filter". i'm under the impression there is a bug in patternly when doing the responsive design behavior ... do you have time to check for this? (you can say not now and I'll log a jira)

@karesti karesti force-pushed the ISPN-14920-counters branch 5 times, most recently from 3df4195 to 4987c51 Compare September 22, 2023 11:16
@karesti
Copy link
Collaborator

karesti commented Sep 22, 2023

failures unrelated

@karesti karesti merged commit ccf1e51 into infinispan:main Sep 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants