Fix #274 - Add eslint-plugin-react-hooks and fix warnings

infinitered · Aug 18, 2020 · 5875ac1 · 5875ac1
1 parent e83e90d
commit 5875ac1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/boilerplate/app/components/switch/switch.tsx b/boilerplate/app/components/switch/switch.tsx
@@ -74,12 +74,9 @@ export function Switch(props: SwitchProps) {
       startAnimation(props.value)
       setPreviousValue(props.value)
     }
-  }, [props.value])
+  }, [previousValue, props.value, startAnimation])
 
-  const handlePress = React.useMemo(() => () => props.onToggle && props.onToggle(!props.value), [
-    props.onToggle,
-    props.value,
-  ])
+  const handlePress = React.useMemo(() => () => props.onToggle && props.onToggle(!props.value), [props])
 
   if (!timer) {
     return null

diff --git a/boilerplate/app/services/reactotron/reactotron.ts.ejs b/boilerplate/app/services/reactotron/reactotron.ts.ejs
@@ -126,6 +126,7 @@ export class Reactotron {
       if (this.config.useAsyncStorage) {
         Tron.setAsyncStorageHandler(AsyncStorage)
       }
+      // eslint-disable-next-line react-hooks/rules-of-hooks
       Tron.useReactNative({
         asyncStorage: this.config.useAsyncStorage ? undefined : false,
       })

diff --git a/boilerplate/package.json.ejs b/boilerplate/package.json.ejs
@@ -79,6 +79,7 @@
     "eslint-plugin-promise": "^4.0.1",
     "eslint-plugin-react": "^7.12.4",
     "eslint-plugin-react-native": "^3.6.0",
+    "eslint-plugin-react-hooks": "^4.1.0",
     "eslint-plugin-standard": "^4.0.0",
     "jest": "25.5.4",
 <% if (props.useExpo) { -%>
@@ -158,6 +159,7 @@
       "plugin:@typescript-eslint/recommended",
       "plugin:react/recommended",
       "plugin:react-native/all",
+      "plugin:react-hooks/recommended",
       "standard"
     ],
     "parserOptions": {