This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Added the ability to generate/scaffold a React.FunctionComponent #300
+178
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nirre7
commented
Dec 29, 2019
•
nirre7
commented
- Added an external styles file to be generated when generating a component.
- Added minor fix for the prettier commands when running zsh (mac osx catalina)
- Fixed typ in readme
# Conflicts: # readme.md
Without the '' it won't work run prettier on nested folders.
|
Oh, so that broke the integration tests in generators-integration.test.ts => since I've added a choice now. |
Updated style reference to be camel case.
|
Looks OK now. |
|
Thanks @nirre7 ! Would you mind adding a "generators" section to the readme? I feel like we lack some documentation on generators and would love to include that with this PR. |
|
Yepp, will add it later today. |
|
@jamonholmgren updated the readme with information regarding generators. |
jamonholmgren
approved these changes
Jan 16, 2020
|
That's excellent! Thanks @nirre7 !!! |
infinitered-circleci
pushed a commit
that referenced
this pull request
Jan 16, 2020
# [4.13.0](v4.12.0...v4.13.0) (2020-01-16) ### Features * **generators:** Added a React.FunctionComponent generator ([#300](#300) by [@nirre7](https://github.com/nirre7)) ([a63bc01](a63bc01))
|
🎉 This PR is included in version 4.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.