Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

pass pre-commit hooks when translation enabled #20

Merged
merged 6 commits into from
Apr 21, 2017

Conversation

ruddell
Copy link
Contributor

@ruddell ruddell commented Mar 23, 2017

  • Moves prompts to before generation
  • Passes prompt answers as props to templates
  • Adds ejs conditions to Tests/Setup.js
  • Changes copy method to ignore ejs files

Fixes infinitered/ignite#911

@ruddell ruddell force-pushed the add-conditions-test-setup branch from ac7d9e4 to efb5830 Compare March 23, 2017 06:21
Copy link
Contributor

@skellock skellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great. I would have just made just made i18n and vector icons hard dependencies because I am lazy.

Your way is the right way. Thank you!

Not sure whats up with the failing test. Will look into that on our end.

@skellock skellock added the bug label Mar 23, 2017
@ruddell
Copy link
Contributor Author

ruddell commented Mar 26, 2017

Fixed the build, there was a lint issue when not using i18n

@GantMan
Copy link
Member

GantMan commented Mar 26, 2017

Whoever merges this, let's make sure these commits get cherry picked to ignite-ir-next as well.
https://github.com/infinitered/ignite-ir-next

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants