-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Expo SDK 50 #2612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impressive work! 🎉 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
boilerplate/jest.config.js
Outdated
@@ -5,7 +5,7 @@ module.exports = { | |||
...tsjPreset, | |||
preset: "jest-expo", | |||
transformIgnorePatterns: [ | |||
"<rootDir>/node_modules/(react-clone-referenced-element|@react-native-community|react-navigation|@react-navigation/.*|@unimodules/.*|native-base|react-native-code-push)", | |||
"<rootDir>/node_modules/(?!((jest-)?react-native|@react-native(-community)?)|expo(nent)?|@expo(nent)?/.*|@expo-google-fonts/.*|react-navigation|@react-navigation/.*|@unimodules/.*|unimodules|sentry-expo|native-base|react-native-svg|react-clone-referenced-element|react-native-code-push)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make it more readable here is a little hack I use
const packagesToTransform = [
"react-native",
"react-native-(.*)",
"@react-native",
"@react-native-community",
"@react-navigation",
"expo",
"expo-(.*)",
"react-native-svg",
"@sentry/.*",
];
/**
* @type {import('@jest/types').Config.InitialOptions}
* */
const config = {
preset: "jest-expo",
// ...
transformIgnorePatterns: [
`node_modules/(?!(${packagesToTransform.join("|")})/)`
],
};
module.exports = config;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot! So much more readable!
I scaffolded a new project from this PR, testing the eas developmnent build does not work. Why did you guys even approve this without trying a build. I hate you all. |
@mattiaferrari02 nice, can you give us a reproductible repository we can dig on? And share the stack trace from expo dashboard 🙏 |
Ciao @mattiaferrari02 ! Alcuni punti:
Thanks for your understanding |
@frankcalise @flexbox apologies for my rudeness. To replicate the issue i followed these steps:
When the app is building in eas an error occurs because of glog. |
@mattiaferrari02 can you provide the output from the command |
# [9.5.0](v9.4.6...v9.5.0) (2024-02-09) ### Features * upgrade to Expo SDK 50 ([#2612](#2612) by [@frankcalise](https://github.com/frankcalise)) ([ff8df47](ff8df47))
🎉 This PR is included in version 9.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn test
jest tests pass with new tests, if relevantREADME.md
has been updated with your changes, if relevantDescribe your PR
jest.config.js
to more closely matchjest-expo
default plus our additionscrashReporting.ts
for Sentry updates with Expo SDK 50eslint-plugin-node