Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures uppercase when creating reducers with the redux generator. #579

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Ensures uppercase when creating reducers with the redux generator. #579

merged 1 commit into from
Jan 3, 2017

Conversation

skellock
Copy link
Contributor

@skellock skellock commented Jan 3, 2017

This is a fix for #578.

The redux generator now will uppercase the createReducer() keys.

@skellock skellock requested a review from GantMan January 3, 2017 15:17
@GantMan
Copy link
Member

GantMan commented Jan 3, 2017

I assume you'll do a second PR on https://github.com/infinitered/ignite/blob/next/packages/ignite-basic-generators/templates/redux.ejs#L43-L45

@skellock
Copy link
Contributor Author

skellock commented Jan 3, 2017

Not sure. Depends on what the name is.

@skellock skellock merged commit 58cc224 into master Jan 3, 2017
@skellock skellock deleted the fix-redux-template-case branch January 3, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GantMan GantMan GantMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skellock @GantMan