Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show graphql operation name for graphql requests #1521

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yurik256
Copy link

@yurik256 yurik256 commented Nov 8, 2024

Please verify the following:

  • yarn build-and-test:local passes
  • I have added tests for any new features, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

On the react native project I'm working on, we are extensively using graphql.
Current implement of timeline plugin, makes it hard to differentiate graphql requests, as they are all shown as POST /graphql in the timeline

This PR improves this by adding the following

  • show operation name for graphql requests
    • This is implemented by parsing request.operationName field, which is automatically added for all graphql requests made by @apollo/client
  • Ability to filter requests by request data

Screenshots

Show operation name
Screenshot 2024-11-08 at 10 41 40 AM

Ability to search by request data ( in this case, operation name )
Screenshot 2024-11-08 at 10 41 59 AM

@yurik256
Copy link
Author

The contributing guide, unfortunately, doesn't specify who should be marked as the reviewer.
@morganick, I see that you reviewed a few recent PRs, would you mind taking a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants