🔺 don't fail on missing check functions (#197)

infinitered · Apr 2, 2018 · 3641d3a · 3641d3a
1 parent eb8020d
commit 3641d3a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/__tests__/command_helpers/checkRequirementPlugins.ts b/__tests__/command_helpers/checkRequirementPlugins.ts
@@ -20,6 +20,21 @@ describe('checkRequirement Plugins', () => {
     expect(result).toEqual(['Boooo failed check'])
   })
 
+  test('CUSTOM and missing check function OK', async () => {
+    mockContext.addPlugin({
+      name: 'Empty Plugin',
+      description: 'I help test plugins',
+      rules: {
+        emptyDude: {}
+      }
+    })
+    const rule = toPairs({
+      TestRequirement: [{ rule: 'custom', plugin: 'Empty Plugin', name: 'emptyDude' }],
+    })[0]
+    const result = await checkRequirement(rule, mockContext)
+    expect(result).toEqual([[]])
+  })
+
   test('failed to find plugin', async () => {
     const rule = toPairs({
       TestRequirement: [{ rule: 'custom', plugin: 'I do not exist', name: 'checkSecondThing' }],

diff --git a/src/extensions/functions/checkRequirement.ts b/src/extensions/functions/checkRequirement.ts
@@ -119,6 +119,8 @@ module.exports = async (
       case 'custom':
         const customPluginRule = findPluginInfo(rule, context)
         if (customPluginRule.success) {
+          // No check provided, we jet
+          if (!customPluginRule.plugin.check) return []
           const customResult = await customPluginRule.plugin.check(rule, context)
           if (customResult && customResult.pass) {
             return addSuccess(customResult.message)