Merge branch 'master' of github.com:infinitered/solidarity

infinitered · Apr 3, 2018 · 56bd42e · 56bd42e
2 parents 6915a9d + 9ed81d3
commit 56bd42e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/__tests__/command_helpers/checkRequirement.ts b/__tests__/command_helpers/checkRequirement.ts
@@ -189,7 +189,7 @@ describe('checkRequirement', () => {
 
     test('failed CLI rule with custom message', async () => {
       checkCLI.mockClear()
-      checkCLI.mockImplementation(() => true)
+      checkCLI.mockImplementation(() => customError)
       const rule = toPairs({
         YARN: [{ rule: 'cli', binary: 'gazorpazorp', error: customError }],
       })[0]
@@ -199,6 +199,8 @@ describe('checkRequirement', () => {
     })
 
     test('failed ENV rule with custom message', async () => {
+      checkCLI.mockClear()
+      checkCLI.mockImplementation(() => true)
       const rule = toPairs({
         YARN: [{ rule: 'env', variable: 'gazorpazorp', error: customError }],
       })[0]

diff --git a/src/extensions/functions/checkRequirement.ts b/src/extensions/functions/checkRequirement.ts
@@ -75,7 +75,7 @@ module.exports = async (
         const cliResult = await checkCLI(rule, context)
         ruleString = `${requirementName} - ${rule.binary} binary`
         if (cliResult) {
-          return addFailure(rule.error || cliResult)
+          return addFailure(cliResult)
         } else {
           return addSuccess(ruleString)
         }