break out helpers and write tests

infinitered · Aug 10, 2018 · 749c1a9 · 749c1a9
1 parent 2edb198
commit 749c1a9
Show file tree

Hide file tree

Showing 4 changed files with 118 additions and 58 deletions.
diff --git a/__tests__/command_helpers/getSolidarityHelpers.ts b/__tests__/command_helpers/getSolidarityHelpers.ts
@@ -0,0 +1,50 @@
+import { isURI, loadFile, loadModule, loadWebCheck } from '../../src/extensions/functions/getSolidarityHelpers'
+
+const context = require('mockContext')
+
+describe('Test helper functions', () => {
+  describe('isURI', () => {
+    test('isURI positive case', () => {
+      expect(isURI('http://www.google.com')).toBeTruthy()
+      expect(isURI('https://www.google.com')).toBeTruthy()
+    })
+
+    test('isURI fail case', () => {
+      expect(isURI('nachos')).toBeFalsy()
+      expect(isURI('/nachos')).toBeFalsy()
+      expect(isURI('./nachos')).toBeFalsy()
+    })
+
+  })
+
+  describe('loadFile', () => {
+    test('loadFile positive cases', () => {
+      expect(loadFile(context, '__tests__/sandbox/solidarity_json')).toBeTruthy()
+      expect(loadFile(context, '__tests__/sandbox/solidarity_json/.solidarity.json')).toBeTruthy()
+    })
+
+    test('loadFile false cases', () => {
+      expect(() => {
+        loadFile(context, '__tests__/sandbox/fake_project')
+      }).toThrow()
+      expect(() => {
+        loadFile(context, '__tests__/sandbox/fake_project/nope.solidarity')
+      }).toThrow()
+    })
+  })
+
+  // describe('loadModule', () => {
+  // })
+
+  describe('loadWebCheck', () => {
+    test('loadWebCheck positive cases', async () => {
+      expect(await loadWebCheck(context, 'https://raw.githubusercontent.com/infinitered/solidarity-stacks/master/stacks/react-native.solidarity')).toBeTruthy()
+    })
+
+    test('loadWebCheck false cases', async () => {
+      await expect(loadWebCheck(context, 'https://raw.githubusercontent.com/infinitered/solidarity-stacks/master/stacks/failsauce'))
+      .rejects
+      .toThrow()
+    })
+  })
+})
diff --git a/__tests__/command_helpers/getSolidaritySettings.ts b/__tests__/command_helpers/getSolidaritySettings.ts
@@ -25,7 +25,7 @@ describe('basic getSolidaritySettings', () => {
     test('getSolidaritySettings can fail', async () => {
 
       // Original sync style
-      // expect(async () => {
+      // expect(() => {
       //   process.chdir('__tests__')
       //   getSolidaritySettings(context)
       // }).toThrow()

diff --git a/src/extensions/functions/getSolidarityHelpers.ts b/src/extensions/functions/getSolidarityHelpers.ts
@@ -0,0 +1,66 @@
+import * as JSON5 from 'json5'
+import * as path from 'path'
+
+const isURI = (path) => !!path.match(/\w+:(\/?\/?)[^\s]+/)
+
+const loadFile = (context, filePath) => {
+  const { filesystem } = context
+  if (filesystem.exists(filePath) === 'file') {
+    return JSON5.parse(filesystem.read(filePath))
+  } else if (filesystem.exists(filePath + path.sep + '.solidarity')) {
+    return JSON5.parse(filesystem.read(filePath + path.sep + '.solidarity'))
+  } else if (filesystem.exists(filePath + path.sep + '.solidarity.json')) {
+    return JSON5.parse(filesystem.read(filePath + path.sep + '.solidarity.json'))
+  } else {
+    throw 'ERROR: There is no solidarity file at the given path'
+  }
+}
+
+const loadModule = (context, moduleName) => {
+  const { filesystem } = context
+  // We will search that module
+  const filePath = path.join('node_modules', moduleName, '.solidarity')
+
+  if (filesystem.exists(filePath)) {
+    return JSON5.parse(filesystem.read(filePath))
+  } else if (filesystem.exists(filePath + '.json')) {
+    return JSON5.parse(filesystem.read(filePath + '.json'))
+  } else {
+    throw 'ERROR: There is no solidarity file found with the given module'
+  }
+}
+
+const loadWebCheck = async (context, checkOption) => {
+  const { print, http } = context
+  const checkSpinner = print.spin(`Running check on ${checkOption}`)
+  // the base URL is throw away, and will go away in next version of apisauce
+  const api = http.create({
+    baseURL: 'https://api.github.com'
+  })
+
+  // Load check from web
+  const checkURL = isURI(checkOption) ? checkOption : `https:\/\/raw.githubusercontent.com/infinitered/solidarity-stacks/master/stacks/${checkOption}.solidarity`
+  const result = await api.get(checkURL)
+  // console.log(result)
+  if (result.ok) {
+    checkSpinner.succeed(`Found Stack: ${checkOption}`)
+    // Convert strings to JSON5 objects
+    const solidarityData = (typeof result.data === 'string')
+      ? JSON5.parse(result.data)
+      : result.data
+    return solidarityData
+  } else {
+    checkSpinner.fail(`Unable to find a known tech stack for ${checkOption}`)
+    print.info(
+      `Check https://github.com/infinitered/solidarity-stacks for options.`
+    )
+    throw(`ERROR: Request failed (${result.status} - ${result.problem})`)
+  }
+}
+
+module.exports = {
+  isURI,
+  loadFile,
+  loadModule,
+  loadWebCheck
+}
diff --git a/src/extensions/functions/getSolidaritySettings.ts b/src/extensions/functions/getSolidaritySettings.ts
@@ -1,62 +1,6 @@
 import { SolidarityRunContext, SolidaritySettings } from '../../types'
+import { loadFile, loadModule, loadWebCheck } from './getSolidarityHelpers'
 import * as JSON5 from 'json5'
-import * as path from 'path'
-
-export const isURI = (path) => !!path.match(/\w+:(\/?\/?)[^\s]+/)
-
-export const loadFile = (context, filePath) => {
-  const { filesystem } = context
-  if (filesystem.exists(filePath + path.sep + '.solidarity')) {
-    return JSON5.parse(filesystem.read(filePath + path.sep + '.solidarity'))
-  } else if (filesystem.exists(filePath + path.sep + '.solidarity.json')) {
-    return JSON5.parse(filesystem.read(filePath + path.sep + '.solidarity.json'))
-  } else if (filesystem.exists(filePath) === 'file') {
-    return JSON5.parse(filesystem.read(filePath))
-  } else {
-    throw 'ERROR: There is no solidarity file at the given path'
-  }
-}
-
-export const loadModule = (context, moduleName) => {
-  const { filesystem } = context
-  // We will search that module
-  const filePath = path.join('node_modules', moduleName, '.solidarity')
-
-  if (filesystem.exists(filePath)) {
-    return JSON5.parse(filesystem.read(filePath))
-  } else if (filesystem.exists(filePath + '.json')) {
-    return JSON5.parse(filesystem.read(filePath + '.json'))
-  } else {
-    throw 'ERROR: There is no solidarity file found with the given module'
-  }
-}
-
-export const loadWebCheck = async (context, checkOption) => {
-  const { print, http } = context
-  const checkSpinner = print.spin(`Running check on ${checkOption}`)
-  const api = http.create({
-    baseURL: 'https://api.github.com'
-  })
-
-  // Load check from web
-  const checkURL = isURI(checkOption) ? checkOption : `https:\/\/raw.githubusercontent.com/infinitered/solidarity-stacks/master/stacks/${checkOption}.solidarity`
-  const result = await api.get(checkURL)
-  // console.log(result)
-  if (result.ok) {
-    checkSpinner.succeed(`Found Stack: ${checkOption}`)
-    // Convert strings to JSON5 objects
-    const solidarityData = (typeof result.data === 'string')
-      ? JSON5.parse(result.data)
-      : result.data
-    return solidarityData
-  } else {
-    checkSpinner.fail(`Unable to find a known tech stack for ${checkOption}`)
-    print.info(
-      `Check https://github.com/infinitered/solidarity-stacks for options.`
-    )
-    throw(`ERROR: Request failed (${result.status} - ${result.problem})`)
-  }
-}
 
 module.exports = async (context: SolidarityRunContext): Promise<SolidaritySettings> => {
   const { filesystem, parameters } = context