Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Danger-JS #154

Merged
merged 23 commits into from
Dec 31, 2017
Merged

Adding Danger-JS #154

merged 23 commits into from
Dec 31, 2017

Conversation

GantMan
Copy link
Member

@GantMan GantMan commented Dec 29, 2017

closes #151

@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files          28       28           
  Lines         534      534           
  Branches       83       83           
=======================================
  Hits          436      436           
  Misses         66       66           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802b478...8ccb991. Read the comment docs.

@TravisBuddy
Copy link
Contributor

Travis tests have failed

Hey Gant Laborde,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci
> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts (21.997s)
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts (7.087s)
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts (6.201s)
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 28 passed, 28 total
Tests:       126 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        84.398s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
⠋ commands/report.ts⠙ commands/snapshot.ts⠹ commands/solidarity.ts⠸ extensions/functions/binaryExists.ts⠼ extensions/functions/checkCLI.ts⠴ extensions/functions/checkCLIForUpdates.ts⠦ extensions/functions/checkDir.ts⠧ extensions/functions/checkENV.ts⠇ extensions/functions/checkFile.ts⠏ extensions/functions/checkRequirement.ts⠋ extensions/functions/checkShell.ts⠙ extensions/functions/getLineWithVersion.ts⠹ extensions/functions/getSolidaritySettings.ts⠸ extensions/functions/getVersion.ts⠼ extensions/functions/printResults.ts⠴ extensions/functions/removeNonVersionCharacters.ts⠦ extensions/functions/reviewRule.ts⠧ extensions/functions/setSolidaritySettings.ts⠇ extensions/functions/updateRequirement.ts⠏ extensions/functions/updateVersions.ts⠋ ./index.tsProcessed 28 files (6.5s) (2 warnings)

✔ No circular dependency found!

Done in 60.90s.

yarn danger -d dangerfile.js
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger -d dangerfile.js

  error: unknown option `-d'

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 8

npm run test:ci
> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts (23.844s)
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts (8.064s)
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts (6.907s)
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 28 passed, 28 total
Tests:       126 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        104.262s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
⠋ commands/report.ts⠙ commands/snapshot.ts⠹ commands/solidarity.ts⠸ extensions/functions/binaryExists.ts⠼ extensions/functions/checkCLI.ts⠴ extensions/functions/checkCLIForUpdates.ts⠦ extensions/functions/checkDir.ts⠧ extensions/functions/checkENV.ts⠇ extensions/functions/checkFile.ts⠏ extensions/functions/checkRequirement.ts⠋ extensions/functions/checkShell.ts⠙ extensions/functions/getLineWithVersion.ts⠹ extensions/functions/getSolidaritySettings.ts⠸ extensions/functions/getVersion.ts⠼ extensions/functions/printResults.ts⠴ extensions/functions/removeNonVersionCharacters.ts⠦ extensions/functions/reviewRule.ts⠧ extensions/functions/setSolidaritySettings.ts⠇ extensions/functions/updateRequirement.ts⠏ extensions/functions/updateVersions.ts⠋ ./index.tsProcessed 28 files (7.2s) (2 warnings)

✔ No circular dependency found!

Done in 44.46s.

yarn danger -d dangerfile.js
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger -d dangerfile.js

  error: unknown option `-d'

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@GantMan GantMan changed the title Danger changer - DO NOT MERGE Adding Danger-JS Dec 31, 2017
@GantMan GantMan merged commit cc87c77 into master Dec 31, 2017
@GantMan GantMan deleted the danger_changer branch December 31, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Danger JS
2 participants