Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist folder - testing and proper building #185

Merged
merged 17 commits into from
May 12, 2018
Merged

Dist folder - testing and proper building #185

merged 17 commits into from
May 12, 2018

Conversation

GantMan
Copy link
Member

@GantMan GantMan commented Mar 7, 2018

Found that dist is not tested in integration and worse yet the templates folder is not being copied to NPM!

@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          33       33           
  Lines         657      657           
  Branches      122      122           
=======================================
  Hits          541      541           
  Misses         78       78           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb132f5...ca418de. Read the comment docs.

@jamonholmgren
Copy link
Member

@GantMan What's the status of this?

@GantMan
Copy link
Member Author

GantMan commented May 11, 2018

I think I had trouble getting it to work on Windows, lots of trouble.

@GantMan
Copy link
Member Author

GantMan commented May 11, 2018

I'm gonna take a look at this once again, and I'll let you know.

@TravisBuddy
Copy link
Contributor

Hey @GantMan,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@TravisBuddy
Copy link
Contributor

Hey @GantMan,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@TravisBuddy
Copy link
Contributor

Hey @GantMan,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@avaGitHubBot
Copy link

avaGitHubBot commented May 11, 2018

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

Generated by 🚫 dangerJS

@TravisBuddy
Copy link
Contributor

Hey @GantMan,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@GantMan GantMan merged commit 936ecf1 into master May 12, 2018
@GantMan GantMan deleted the integration_tests branch May 12, 2018 01:39
@jamonholmgren
Copy link
Member

Man that TravisBuddy bot is annoying.

@tabrindle
Copy link
Contributor

tabrindle commented May 12, 2018 via email

@jamonholmgren
Copy link
Member

@GantMan Can we disable the Travis bot please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants