-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable solidarity file locations with -f and -m #199
Conversation
Travis tests have failedHey @GantMan, Node.js: 8npm run test:ci
|
Travis tests have failedHey @GantMan, Node.js: 8npm run test:ci
|
Travis tests have failedHey @GantMan, Node.js: 8npm run test:ci
|
Travis tests have failedHey @GantMan, Node.js: 8npm run test:ci
|
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
========================================
+ Coverage 82.1% 83% +0.89%
========================================
Files 33 33
Lines 637 653 +16
Branches 112 121 +9
========================================
+ Hits 523 542 +19
Misses 78 78
+ Partials 36 33 -3
Continue to review full report at Codecov.
|
Partial of #162 - gives the ability to specify a solidarity file outside of current directory.
--solidarityFile
or-f
for the pathALSO adds the ability to specify a module for providing solidarity file.
--module
or-m
-> This will give us the ability to do checks specific to a specific lib/module when reporting issues.More docs needed for users to know/use this.