Set buttonType to empty by default

infinum · Dec 5, 2024 · 1f62bcb · 1f62bcb
1 parent 5ab1bb0
commit 1f62bcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/blocks/init/src/Blocks/components/button/button.php b/blocks/init/src/Blocks/components/button/button.php
@@ -19,6 +19,7 @@
 $additionalClass = $attributes['additionalClass'] ?? '';
 $additionalAttributes = $attributes['additionalAttributes'] ?? [];
 $buttonId = Helpers::checkAttr('buttonId', $attributes, $manifest);
+$buttonType = Helpers::checkAttr('buttonType', $attributes, $manifest);
 
 $buttonUrl = Helpers::checkAttr('buttonUrl', $attributes, $manifest);
 $buttonIsNewTab = Helpers::checkAttr('buttonIsNewTab', $attributes, $manifest);
@@ -60,8 +61,8 @@
 
 $buttonTag = !empty($buttonUrl) ? 'a' : 'button';
 
-if (empty($buttonUrl)) {
-	$buttonAttrs['type'] = Helpers::checkAttr('buttonType', $attributes, $manifest);
+if (empty($buttonUrl) && !empty($buttonType)) {
+	$buttonAttrs['type'] = $buttonType;
 }
 ?>
 

diff --git a/blocks/init/src/Blocks/components/button/manifest.json b/blocks/init/src/Blocks/components/button/manifest.json
@@ -22,7 +22,7 @@
 		},
 		"buttonType": {
 			"type": "string",
-			"default": "button"
+			"default": ""
 		},
 		"buttonColor": {
 			"type": "string",