Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image component class output #65

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

piqusy
Copy link
Contributor

@piqusy piqusy commented Dec 3, 2024

Description

The $additionalClass for the image part was falling back to an array instead of empty string which throws an error in the eightshift-libs/src/Helpers/SelectorsTrait.php:135 implode() method.

@piqusy piqusy added the bug Something isn't working label Dec 3, 2024
@piqusy piqusy added this to the 1.4.7 milestone Dec 3, 2024
@piqusy piqusy requested a review from a team December 3, 2024 10:15
@piqusy piqusy self-assigned this Dec 3, 2024
@piqusy piqusy merged commit 35428ae into release/1.4.7 Dec 3, 2024
1 check failed
@piqusy piqusy deleted the fix/image-component-class-output branch December 3, 2024 10:57
@piqusy piqusy restored the fix/image-component-class-output branch December 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants