Major update on WP-CLI and setup #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # blocks/init/src/Blocks/components/copyright/copyright.php # blocks/init/src/Blocks/custom/site-footer/site-footer.php
goranalkovic-infinum
previously approved these changes
May 15, 2024
piqusy
previously approved these changes
May 15, 2024
| @@ -12,7 +12,7 @@ export const CopyrightOptions = (attributes) => { | |||
|
|
|||
| return ( | |||
| <Toggle | |||
| label={__('Copyright', 'eightshift-frontend-libs')} | |||
| label={__('Copyright', '%g_textdomain%')} | |||
There was a problem hiding this comment.
I'm probably missing something but how come this textdomain convention is only used in this and site-footer-options.js files?
There was a problem hiding this comment.
this was all done for the other blocks in the previous PR so I fixed the additional changes Kanc did for this block
There was a problem hiding this comment.
Oh, it seems that I've clicked on a link for a single commit and saw just that small change 😄
iruzevic
dismissed stale reviews from piqusy and goranalkovic-infinum
via
1c3dfb3
goranalkovic-infinum
approved these changes
May 15, 2024
piqusy
approved these changes
May 15, 2024
| @@ -104,7 +104,7 @@ export const FeaturedContentOptions = ({ attributes, setAttributes }) => { | |||
| }); | |||
| }} | |||
|
|
|||
| // placeholder={__('All', 'eightshift-frontend-libs')} | |||
| // placeholder={__('All', '%g_textdomain%')} | |||
There was a problem hiding this comment.
Should it stay or should it go?
iobrado
approved these changes
May 15, 2024
iruzevic
added a commit
that referenced
this pull request
Jun 5, 2024
* fixing global manifest and cssVariables functions * fixing getManifest function * fixing render methods * fixing renderPartial function * updating new wrapper * adding changelog --------- Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Bump glob-parent from 3.1.0 to 5.1.2 in /setup/create-wp-project (#783) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 3.1.0 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v3.1.0...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Standardize Accessibility of Quote Blocks Across Browsers (#828) * added escaping function * change figure role to presentation * simplify the block to be interpreted same across the browsers Use existing copyright component in footer (#827) * use existing copyright component in footer * removed typography component from copyright * return getManifestByDir Bug/failure due to manifest selection (#822) * Revert "Frontend libs 9.5.0" * sync files * This regex ensures that only files named exactly manifest.json are matched --------- Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Major update on WP-CLI and setup (#826) * Major update on WP-CLI and setup fixes fixes fixes fixes fixes updating dependencies updating dependencies updating dependencies release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependant to Eightshift-libs@8.0.0
Changed
Components::getManifesttoComponents::getManifestByDirmethod.Components::outputCssVariables($attributes, $manifest, $unique, $globalManifest)toComponents::outputCssVariables($attributes, $manifest, $unique).renderPartialtorendermethod.$this->renderWrapperViewtoecho $renderContent;.