-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exctract handles to public methods #306
Exctract handles to public methods #306
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #306 +/- ##
=============================================
+ Coverage 79.74% 81.12% +1.37%
- Complexity 1187 1195 +8
=============================================
Files 131 131
Lines 3584 3602 +18
=============================================
+ Hits 2858 2922 +64
+ Misses 726 680 -46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, can you add tests for the new methods? Ping me if you need help 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Description
Extract all handles to public methods so that they can be reused if needed.