Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exctract handles to public methods #306

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

JerrySpecter
Copy link
Contributor

Description

Extract all handles to public methods so that they can be reused if needed.

@JerrySpecter JerrySpecter requested a review from a team June 28, 2022 10:03
@JerrySpecter JerrySpecter self-assigned this Jun 28, 2022
@JerrySpecter JerrySpecter linked an issue Jun 28, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #306 (03d18a1) into develop (3bcc694) will increase coverage by 1.37%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop     #306      +/-   ##
=============================================
+ Coverage      79.74%   81.12%   +1.37%     
- Complexity      1187     1195       +8     
=============================================
  Files            131      131              
  Lines           3584     3602      +18     
=============================================
+ Hits            2858     2922      +64     
+ Misses           726      680      -46     
Flag Coverage Δ
unittests 81.12% <100.00%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Enqueue/Admin/AbstractEnqueueAdmin.php 100.00% <100.00%> (+7.40%) ⬆️
src/Enqueue/Blocks/AbstractEnqueueBlocks.php 100.00% <100.00%> (ø)
src/Enqueue/Theme/AbstractEnqueueTheme.php 100.00% <100.00%> (ø)
src/Geolocation/AbstractGeolocation.php 98.18% <0.00%> (+80.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bcc694...03d18a1. Read the comment docs.

iruzevic
iruzevic previously approved these changes Jun 28, 2022
Copy link
Collaborator

@dingo-d dingo-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, can you add tests for the new methods? Ping me if you need help 🙂

gabriel-glo
gabriel-glo previously approved these changes Jun 28, 2022
@dingo-d dingo-d dismissed stale reviews from gabriel-glo and iruzevic via 75db229 June 28, 2022 12:06
Copy link
Collaborator

@dingo-d dingo-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@JerrySpecter JerrySpecter merged commit 7bfae64 into develop Jun 30, 2022
@JerrySpecter JerrySpecter deleted the add/119-asset-handle-as-public-constant branch June 30, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset handle should be a public constant
5 participants