Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider undefined/null for optional rust types (close #278) #280

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Consider undefined/null for optional rust types (close #278) #280

merged 3 commits into from
Nov 17, 2023

Conversation

DmitryAstafyev
Copy link
Contributor

Before parsing value from JS and converting it into rust-type, checking for null / undefined and consider it as Option<T>

@DmitryAstafyev
Copy link
Contributor Author

related to #278

@DmitryAstafyev DmitryAstafyev mentioned this pull request Nov 17, 2023
Closed
@morenol
Copy link
Contributor

morenol commented Nov 17, 2023

@DmitryAstafyev can you rebase on #281 is merged?

Can we add a new test/example for this case?

@DmitryAstafyev
Copy link
Contributor Author

@DmitryAstafyev can you rebase on #281 is merged?

Can we add a new test/example for this case?

done

@DmitryAstafyev
Copy link
Contributor Author

@morenol tests are green )

@DmitryAstafyev
Copy link
Contributor Author

DmitryAstafyev commented Nov 17, 2023 •
edited
Loading

@morenol

Can we add a new test/example for this case?

Sorry, missed this question. I guess, yes... give me a try

@DmitryAstafyev
Copy link
Contributor Author

@morenol test has been added. Test has been passed ) we are green

morenol
morenol approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM!

@morenol morenol requested a review from sehz November 17, 2023 21:43
sehz
sehz approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job

@sehz sehz added this pull request to the merge queue Nov 17, 2023
@sehz sehz added the enhancement New feature or request label Nov 17, 2023
Merged via the queue into infinyon:master with commit 2b2ac97 Nov 17, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morenol morenol morenol approved these changes

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitryAstafyev @morenol @sehz