Add socket.io ack support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 22, 2019 10:00
socket.emitWithAck("message", ["Hello world!"]).then( (data) {
// this callback runs when this specific message is acknowledged by the server
print(data);
});
When ACK is requested, a Future is returned, which will be completed once the
server acknowledges the request. Note that there is no guarantee that the server
will ever acknowledge the request, and the current implementation does not provide
any timeout or garbage collection mechanism.
tiholic
reviewed
Jul 12, 2019
| arguments = arguments.where((_) { | ||
| //TODO this works around difference in ios (doesn't eat nulls) and android (eats nulls) | ||
| return _ != null; | ||
| }).toList().map((_) { |
There was a problem hiding this comment.
This toList can be skipped as .map is applicable on an Iterable
tiholic
reviewed
Jul 12, 2019
| @@ -98,6 +129,18 @@ class SocketIO { | |||
| 'arguments': arguments, | |||
| }); | |||
| } | |||
| ///send data to socket server, return expected Ack as a Future | |||
| emitWithAck(String eventName, List<dynamic> arguments) async { | |||
There was a problem hiding this comment.
A return type in method signature would be good as it is returning!
tiholic
reviewed
Jul 12, 2019
There was a problem hiding this comment.
@vornado22 an example to test in example/socket.io.server/index.js would be great!
|
I'm having this error when trying to run it on branch master, and it might be related with the pull request : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add callback support upon server ack after emit: