Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark reqId as Optional Fix #55 #57

Merged
merged 3 commits into from
Aug 18, 2019
Merged

mark reqId as Optional Fix #55 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5857e8b
Update AdharaSocket.swift
Saifallak Aug 18, 2019
ee0b27c
add +1 (patch update)
Saifallak Aug 18, 2019
ba1f2b5
Update CHANGELOG.md
Saifallak Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.3+1 - 18th August, 2019

* [PR 57](https://github.com/infitio/flutter_socket_io/pull/57) fix for iOS (reqId wasn't optional) @Saifallak

## 0.3.3 - 14th August, 2019

* Typo fix for nameSpace ( changed SocketOptions.namesapce to SocketOptions.nameSpace )
Expand Down
2 changes: 1 addition & 1 deletion ios/Classes/AdharaSocket.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public class AdharaSocket: NSObject, FlutterPlugin {
case "emit":
let eventName: String = arguments["eventName"] as! String
let data: [Any] = arguments["arguments"] as! [Any]
let reqId: String = arguments["reqId"] as! String
let reqId: String? = arguments["reqId"] as? String
self.log("emitting:::", data, ":::to:::", eventName);
if (reqId == nil) {
socket.emit(eventName, with: data)
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: adhara_socket_io
description: Websocket by socket.io for flutter by adhara, supports both iOS and Android
version: 0.3.3
version: 0.3.3+1
author: Rohit R. Abbadi <rohit@infitio.com>
homepage: https://github.com/infitio/flutter_socket_io

Expand Down