chore(ui): upgrade dependencies #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
force-pushed
the
chore/upgrade_deps_20220324
branch
from
36a2422 to
e42ad59
Compare
sranka
commented
Apr 1, 2022
| @@ -332,7 +336,7 @@ export const updateTagFilterAsync = ( | |||
|
|
|||
| try { | |||
| dispatch(updateTagFilter(dashboardID, tagFilter)) | |||
| await dispatch(getAnnotationsAsync(indexURL, dashboardID)) | |||
| await getAnnotationsAsync(indexURL, dashboardID)(dispatch, getState) | |||
There was a problem hiding this comment.
The await statement was repaired to be effective, the original await was malformed (did nothing)
| @@ -115,7 +115,7 @@ export const DEFAULT_THRESHOLDS_LIST_COLORS = [ | |||
| hex: THRESHOLD_COLORS[11].hex, | |||
| id: THRESHOLD_TYPE_BASE, | |||
| name: THRESHOLD_COLORS[11].name, | |||
| value: -999999999999999999, | |||
| value: -1000000000000000000, | |||
There was a problem hiding this comment.
-999999999999999999 (as a number constant) loses precision, eslint complains about it
sranka
force-pushed
the
chore/upgrade_deps_20220324
branch
from
8d7f2e4 to
17c2d5d
Compare
ivankudibal
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades existing yarn.lock dependencies using
yarn upgrade --latesttypescript(4.6.3),eslintto support the newest typescript, andbabelIt also includes a bunch of fixes after upgrade as described by particular git commit messages, most of them are about fixing redux/redux-thunk type definitions.