Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version detection #6116

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix: version detection #6116

merged 4 commits into from
Dec 11, 2024

Conversation

vlastahajek
Copy link
Contributor

@vlastahajek vlastahajek commented Nov 29, 2024

Briefly describe your proposed changes:
What was the problem?
Workaround for query adjustment for InfluxDB 1 didn't count with InfluxDB Enterprise
What was the solution?
Check also Enterprise build

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml
  • swagger.json updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@vlastahajek vlastahajek marked this pull request as draft November 29, 2024 10:29
@vlastahajek vlastahajek changed the title Fix: Version detecton Fix: Version detection Nov 29, 2024
@vlastahajek vlastahajek marked this pull request as ready for review December 4, 2024 09:26
@vlastahajek vlastahajek requested a review from bednar December 4, 2024 09:26
@vlastahajek vlastahajek force-pushed the fix/version-detection branch from e5242ef to 677f486 Compare December 4, 2024 09:54
@bednar bednar changed the title Fix: Version detection fix: version detection Dec 4, 2024
@bednar bednar requested review from karel-rehor and removed request for bednar December 4, 2024 13:41
Copy link

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually reviewed against

  • Influxdb Enterprise (version=v1.11.8) docker - solo deployment against solo meta node
  • Influxdb-v1 OSS (version=v1.11.8) docker
  • Influxdb-v2 OSS docker (v2.7.11).

Connected to telegraf and reviewed tag listings in

  • Explorer
  • Dashboard > Configure

The following path was checked:
flux > telegraf.autogen > cpu > usage_nice > [cpu|host|user]

Tags are now being listed.

Changes here all make sense.

@vlastahajek vlastahajek merged commit 78dbc05 into master Dec 11, 2024
3 checks passed
@vlastahajek vlastahajek deleted the fix/version-detection branch December 11, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants