Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RestSharp nuget package #648

Closed
wants to merge 1 commit into from
Closed

add RestSharp nuget package #648

wants to merge 1 commit into from

Conversation

atias007
Copy link

Proposed Changes

  • Update RestSharp nuget
  • Replace MaxTimeout (int) of RestClientOption to Timeout (TimeSpan)
  • Fix the Execute() of RestClient which now don't get CancellationToken to ExecuteAsync().Result

Closes #

@customs-il
add RestSharp nuget package
85287f3 
replace MaxTimeout (int) of RestClientOption to Timeout (TimeSpan)
fix the Execute() of RestClient which now dont get CancellationToken to ExecuteAsync().Result
@bednar
Copy link
Contributor

bednar commented Jul 22, 2024

Hi @atias007,

Thank you for your PR. I've created an enhanced PR that will also refactor our codebase to accommodate new APIs from RestSharp. Stay tuned and check the progress at #650.

Best Regards

@bednar bednar closed this Jul 22, 2024
@bednar bednar added this to the 4.17.0 milestone Jul 22, 2024
@bednar bednar added the duplicate This issue or pull request already exists label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atias007 @bednar @customs-il