Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async queries also uses HttpCompletionOption.ResponseHeadersRead #649

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix: async queries also uses HttpCompletionOption.ResponseHeadersRead #649

merged 3 commits into from
Jul 22, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 22, 2024 •
edited
Loading

Related to #632 (comment)

Proposed Changes

Use HttpCompletionOption.ResponseHeadersRead also for async queries for possibility to use large queries then 2GiB.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar changed the title Async requests response headers read fix: async query request also uses HttpCompletionOption.ResponseHeadersRead Jul 22, 2024
@bednar bednar changed the title fix: async query request also uses HttpCompletionOption.ResponseHeadersRead fix: async queries also uses HttpCompletionOption.ResponseHeadersRead Jul 22, 2024
@bednar bednar mentioned this pull request Jul 22, 2024
Merged
6 tasks
@bednar bednar marked this pull request as ready for review July 22, 2024 04:45
@bednar bednar requested a review from karel-rehor July 22, 2024 04:45
karel-rehor
karel-rehor approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Changes make sense.

@bednar bednar merged commit 70fb7e1 into master Jul 22, 2024
10 of 17 checks passed
@bednar bednar deleted the async-requests-response-headers-read branch July 22, 2024 09:37
@bednar bednar added this to the 4.17.0 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karel-rehor karel-rehor karel-rehor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bednar @karel-rehor