Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Custom checks de/serialization #403

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix: Custom checks de/serialization #403

merged 3 commits into from
Aug 7, 2024

Conversation

vlastahajek
Copy link
Contributor

Closes #371

Proposed Changes

Fixed wrongly generated checks de/serialization

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@vlastahajek vlastahajek requested a review from bednar August 7, 2024 13:19
bednar
bednar requested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍. There is only small requirement to be ready for release next week:

CHANGELOG.md Outdated
@@ -1,3 +1,8 @@
## Unreleased
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to ensure it's the same as in other clients before next week's release ;)

Suggested change
## Unreleased
## 2.14.0 [unreleased]

bednar
bednar approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vlastahajek vlastahajek merged commit b3496ca into influxdata:master Aug 7, 2024
2 checks passed
@bednar bednar added this to the 2.14.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

APIClient().GetChecks return null checks
2 participants
@vlastahajek @bednar