We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPResponse.getheader()
HTTPResponse.getheaders()
Every call of HTTPResponse.getheader() and HTTPResponse.getheaders().
Work without Deprecation Warnings.
The following warnings are raised:
HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default).
HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
See https://github.com/urllib3/urllib3/blob/53368dfe6609aec8f3d933b62021cf568f24b794/src/urllib3/response.py#L478C6-L478C6 for warning origin.
The text was updated successfully, but these errors were encountered:
Hi @swssl,
thanks for using our client.
Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.
Regards
Sorry, something went wrong.
Hi @bednar , thanks for your reply. Unfortunately, i won't be available to work on this on short notice but i'll keep it in mind.
Hey all, FYI, urllib3 v2.1.0 was released last week: https://github.com/urllib3/urllib3/releases/tag/2.1.0 As far as I can tell, it doesnt contain the changes the warning is about. @bednar Maybe I will be able to work on this in the end of January.
@swssl, thanks 🙏
alespour
Successfully merging a pull request may close this issue.
Specifications
Code sample to reproduce problem
Every call of
HTTPResponse.getheader()
andHTTPResponse.getheaders()
.Expected behavior
Work without Deprecation Warnings.
Actual behavior
The following warnings are raised:
HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default).
HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
Additional info
See https://github.com/urllib3/urllib3/blob/53368dfe6609aec8f3d933b62021cf568f24b794/src/urllib3/response.py#L478C6-L478C6 for warning origin.
The text was updated successfully, but these errors were encountered: