Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated urllib calls #655

Merged
merged 4 commits into from
May 14, 2024
Merged

fix: deprecated urllib calls #655

merged 4 commits into from
May 14, 2024

Conversation

alespour
Copy link
Contributor

@alespour alespour commented May 13, 2024

Closes #602

Proposed Changes

Replaces deprecated urllib lib calls:

  • HTTPResponse.getheaders() with HTTPResponse.headers`
  • HTTPResponse.getheader(name, default) with HTTPResponse.headers.get(name, default)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional

@alespour alespour changed the title Fix/deprecated urllib call fix: deprecated urllib calls May 13, 2024
@alespour alespour force-pushed the fix/deprecated-urllib-call branch from eaed4e8 to 99bdd38 Compare May 13, 2024 10:46
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (0047fa9) to head (05e1bf2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   90.41%   90.42%   +0.01%     
==========================================
  Files          39       39              
  Lines        3505     3510       +5     
==========================================
+ Hits         3169     3174       +5     
  Misses        336      336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review May 13, 2024 14:20
@alespour alespour requested review from karel-rehor and bednar May 14, 2024 11:25
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Changes make sense,

@alespour alespour merged commit 08acb17 into master May 14, 2024
17 checks passed
@alespour alespour deleted the fix/deprecated-urllib-call branch May 14, 2024 12:14
@bednar bednar added this to the 1.43.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urllib3 v2.0.3 Deprecation Warnings on HTTPResponse.getheader() and HTTPResponse.getheaders()
4 participants