-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: serialization of dataframes with NaN values and columns starting with digits #486
fix: serialization of dataframes with NaN values and columns starting with digits #486
Conversation
9ba3d6a
to
521e53a
Compare
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 89.42% 89.42%
=======================================
Files 39 39
Lines 3347 3347
=======================================
Hits 2993 2993
Misses 354 354
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e291c5e
to
b620f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your PR 👍
There is only one requirement about README.md
before we are be able merge your PR:
b620f8c
to
d2dc490
Compare
d2dc490
to
ae4110d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fdorssers thanks again for the PR 👍
LGTM 🚀
No problem! Been using Influx for a while now, glad to contribute something back! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix and a test!
Closes #485
Proposed Changes
Update the regex string that's supposed to remove spurious leading commas in case the first field is None/NaN by also checking whether the first character of a column is a digit.
Locally
pytest tests
wasn't able to complete successfully due to an error inInfluxDBClientAsyncTest.test_delete_api
. But I'm assuming that's due to a setup issue.Checklist
pytest tests
completes successfully