Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: possibility to precise which config name to load when loading config from file #586

Merged
merged 13 commits into from
Jun 29, 2023
Merged

feat: possibility to precise which config name to load when loading config from file #586

merged 13 commits into from
Jun 29, 2023

Conversation

aaalloc
Copy link
Contributor

@aaalloc aaalloc commented Jun 23, 2023

Closes #585

Proposed Changes

Possibility to precise which config name we want when loading from_config_file

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (77cac49) 90.30% compared to head (3577c58) 90.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          39       39           
  Lines        3455     3456    +1     
=======================================
+ Hits         3120     3121    +1     
  Misses        335      335           
Impacted Files Coverage Δ
influxdb_client/client/influxdb_client.py 98.78% <ø> (ø)
influxdb_client/client/influxdb_client_async.py 88.52% <ø> (ø)
influxdb_client/client/_base.py 97.72% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aaalloc aaalloc changed the title Features : from_config_file() config_name argument added feat: from_config_file() config_name argument added Jun 24, 2023
@aaalloc aaalloc changed the title feat: from_config_file() config_name argument added feat: possibility to precise which config name to load when loading config from file Jun 24, 2023
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:

  1. Please update CHANGELOG.md
  2. Please satisfy following requirements:

@aaalloc aaalloc requested a review from bednar June 27, 2023 09:20
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍

Please change implementation to use kwargs instead of new argument:

@aaalloc aaalloc requested a review from bednar June 28, 2023 17:03
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR, everything looks good 🚀

@bednar bednar merged commit 0be41d1 into influxdata:master Jun 29, 2023
@bednar bednar added this to the 1.35.0 milestone Jun 29, 2023
@bednar bednar modified the milestones: 1.35.0, 1.37.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify header name for from_config_file() function
3 participants