-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: possibility to precise which config name to load when loading config from file #586
feat: possibility to precise which config name to load when loading config from file #586
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 39 39
Lines 3455 3456 +1
=======================================
+ Hits 3120 3121 +1
Misses 335 335
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:
- Please update CHANGELOG.md
- Please satisfy following requirements:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
Please change implementation to use kwargs
instead of new argument:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR, everything looks good 🚀
Closes #585
Proposed Changes
Possibility to precise which config name we want when loading from_config_file
Checklist
pytest tests
completes successfully