Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate columns warning shows in improper situations #123

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 2, 2022

Proposed Changes

The duplicated columns warning shows in improper situations - always 😞.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review November 2, 2022 07:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Base: 51.12% // Head: 51.12% // No change to project coverage 👍

Coverage data is based on head (09f6f06) compared to base (1f9a854).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   51.12%   51.12%           
=======================================
  Files          65       65           
  Lines        6355     6355           
=======================================
  Hits         3249     3249           
  Misses       3106     3106           
Impacted Files Coverage Δ
lib/influxdb2/client/client.rb 100.00% <ø> (ø)
lib/influxdb2/client/flux_csv_parser.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar merged commit c2bc31d into master Nov 2, 2022
@bednar bednar deleted the fix-duplicated-column branch November 2, 2022 10:11
@bednar bednar added this to the 2.9.0 milestone Nov 2, 2022
ledermann added a commit to solectrus/solectrus that referenced this pull request Nov 5, 2022
2.8.0 prints warnings like "The response contains columns with duplicated names: label"

2.9.0 will fix this:
influxdata/influxdb-client-ruby#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants