signal end-of-chunking #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #270 +/- ##
============================================
- Coverage 71.2% 70.89% -0.31%
Complexity 123 123
============================================
Files 11 11
Lines 698 701 +3
Branches 76 76
============================================
Hits 497 497
- Misses 159 162 +3
Partials 42 42
Continue to review full report at Codecov.
|
|
Hello guys, did you get a chance to look at this one? I believe both changes are necessary. Open to suggestions if someone has a better solution. Thanks! |
|
+1 |
|
Hi, I would take the first LinkedBlockingQueue enhancement, but you must add some unit tests to cover the additional code. Your second modification is a different topic and should therefore be discussed in a different PR. |
added 2 commits
February 9, 2017 17:13
|
Not sure why codecoverage fails, I added test cases for the additional lines. Can CodeCov tests be restartet? |
|
Great! Thanks Stefan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no more QueryResults coming in through chunking we should signal this to the consumer in some way. I suggest that we use some sort of "poison pill" for this. I added a special error message (with text "DONE") to the final QueryResult. I'm open to different options if someone has a better idea.
Thanks!