Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biconsumer exception callback #319

Merged
merged 9 commits into from
May 11, 2017

Conversation

csokol
Copy link
Contributor

@csokol csokol commented May 11, 2017

Alternative implementation of #318

@csokol
Copy link
Contributor Author

csokol commented May 11, 2017

Check it out, @majst01 @kkarski.

If you prefer this implementation, I'll change the readme.

@csokol csokol force-pushed the biconsumer-exception-callback branch from c2139fd to bb394f2 Compare May 11, 2017 10:16
@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #319 into master will increase coverage by 0.62%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #319      +/-   ##
============================================
+ Coverage     79.04%   79.66%   +0.62%     
- Complexity      135      137       +2     
============================================
  Files            11       11              
  Lines           711      723      +12     
  Branches         77       78       +1     
============================================
+ Hits            562      576      +14     
+ Misses          107      106       -1     
+ Partials         42       41       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/InfluxDB.java 100% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/org/influxdb/impl/InfluxDBImpl.java 82.69% <100%> (+0.25%) 43 <1> (+1) ⬆️
...rc/main/java/org/influxdb/impl/BatchProcessor.java 98.13% <100%> (+0.17%) 17 <8> (ø) ⬇️
src/main/java/org/influxdb/dto/Point.java 83.33% <0%> (+1.33%) 24% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d315a...0f57e39. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented May 11, 2017

Great thanks, i like it.

@csokol
Copy link
Contributor Author

csokol commented May 11, 2017

Cool, I've fixed the readme, I think this is ready to be merged.

@majst01
Copy link
Collaborator

majst01 commented May 11, 2017

One missing nit: Changelog entry

@majst01 majst01 merged commit a2ddba4 into influxdata:master May 11, 2017
@csokol
Copy link
Contributor Author

csokol commented May 11, 2017 via email

@majst01
Copy link
Collaborator

majst01 commented May 11, 2017

I will trigger the people from influxdata because they are only able to push to maven central.

Copy link

@kkarski kkarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@csokol
Copy link
Contributor Author

csokol commented May 15, 2017

@majst01 were the influxdata guys able to release the snapshot?

@majst01
Copy link
Collaborator

majst01 commented May 15, 2017

I am in contact with them, please be patient.

@csokol
Copy link
Contributor Author

csokol commented May 29, 2017

@majst01 any updates on that? sorry, I don't want to be a pusher but it's been two weeks already :)

If you think it will still take long I'll ship a local jar in our application, just let me know.

@majst01
Copy link
Collaborator

majst01 commented May 29, 2017

Im still waiting for the influxdb guys to push to maven central. i will ask again. sorry

@dmullaney
Copy link

Has there been any progress on getting a release for this feature?

@majst01
Copy link
Collaborator

majst01 commented Jun 8, 2017

it is released !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants