-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop guava runtime dependency #322
Conversation
In general i agree with this, but this PR has to much modifications, changes formatting of lines which are not affected, error messages are different, tests are failing. If you are trying to improve this i can accept tis. |
7f022a6
to
f33d3fb
Compare
I just fixed the checkstyle issues (which caused the tests to fail). There shouldn't be any unrelated formatting changes, though. |
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
============================================
+ Coverage 79.54% 80.59% +1.05%
- Complexity 140 147 +7
============================================
Files 13 14 +1
Lines 743 737 -6
Branches 77 67 -10
============================================
+ Hits 591 594 +3
+ Misses 109 107 -2
+ Partials 43 36 -7
Continue to review full report at Codecov.
|
Ok looks better, i wait til 2.6 is published to maven repo and we can then consider merging for the next release. |
867aa22
to
bbb28ab
Compare
Thanks for reviewing this PR and maintaining this Java project! 👍 |
@simon04 would you please resolve the merge conflict, after that i will merge. |
Done. |
Some fuctionality is provided by Java 8, the remaining parts can easily be rewritten.