Simplify write() methods for use cases writing all points to same database and retention policy #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 30, 2017 11:34
- Added optional state to InfluxDB interface and implementation to provide database, retention policy, and consistency - Added new write() methods based on non-batch point calls to remove need to specify database, retention policy, and consistency - Added tests around new write() methods - Added .m2 directory to git ignore
|
Could use a little help identifying the checkstyle errors as helper script output isn't super helpful. |
majst01
added a commit
that referenced
this pull request
Jun 13, 2017
majst01
added a commit
that referenced
this pull request
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More often than not, applications are going to write points to a specific database and retention policy, however it's tedious passing around configuration for writes. Instead there should be simpler write() methods for non-BatchPoints calls that uses defaults set at the client layer instead of the usage statement.