-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple but significant performance improvements. #330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
============================================
+ Coverage 79.66% 79.91% +0.24%
Complexity 137 137
============================================
Files 11 11
Lines 723 732 +9
Branches 78 76 -2
============================================
+ Hits 576 585 +9
+ Misses 106 104 -2
- Partials 41 43 +2
Continue to review full report at Codecov.
|
Can you show how big the performance improvements are ? |
Locally measured. Current:
New:
|
More difficult to measure, though measurable, and not insignificant, is the reduction of garbage. |
Great thanks, i will merge it in the next iteration. |
@majst01 Thanks! We may have more contributions in the coming weeks. |
… and generates > 800MB less garbage in the PerformanceTests.maxWritePointsPerformance() test compared to the master branch.
Latest commit gets the |
@majst01 A few questions. I see that v2.5 was released six months ago, and the general cadence seems to be 3-6mo between releases. When is v2.6 slated for release? And what is the reason this commit is scheduled for 2.7? That would imply a wait of 6-9 months before we see this commit in a release version. |
Oh no, 2.6 should be released in the next few days if not already release (it depends on support from som influxdata guys). |
2.6 is finally released. |
@majst01 Thanks! |
Hi Brett, one last nit, can you please add a proper changelog entry, after that i will merge it. |
No description provided.