Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryResult to Object mapper added #341

Merged
merged 4 commits into from
Jun 23, 2017
Merged

QueryResult to Object mapper added #341

merged 4 commits into from
Jun 23, 2017

Conversation

fmachado
Copy link
Contributor

in ref to #340

@fmachado fmachado changed the title QueryResult to Object mapper added #340 QueryResult to Object mapper added Jun 21, 2017
@codecov-io
Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #341 into master will increase coverage by 2.73%.
The diff coverage is 86.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #341      +/-   ##
============================================
+ Coverage      80.1%   82.84%   +2.73%     
- Complexity      151      195      +44     
============================================
  Files            14       16       +2     
  Lines           754      880     +126     
  Branches         66       88      +22     
============================================
+ Hits            604      729     +125     
+ Misses          115      111       -4     
- Partials         35       40       +5
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/influxdb/InfluxDBMapperException.java 33.33% <33.33%> (ø) 1 <1> (?)
...n/java/org/influxdb/impl/InfluxDBResultMapper.java 89.16% <89.16%> (ø) 41 <41> (?)
src/main/java/org/influxdb/impl/InfluxDBImpl.java 80.8% <0%> (+0.44%) 47% <0%> (+1%) ⬆️
src/main/java/org/influxdb/dto/QueryResult.java 92.59% <0%> (+27.77%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205fc1d...c79770e. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Jun 21, 2017

Hi @fmachado

thanks for the effort !
I would prefer to have it in the same package structure not necessarily below "pojomapper".
The annotations can go into its own subpackage "annotations" but all other should be in impl.
what do you think.

@fmachado
Copy link
Contributor Author

Done. :) Do you want me to update the main README.md file?

@majst01
Copy link
Collaborator

majst01 commented Jun 23, 2017

Excellent, a explanation which a note that this feature as since 2.7 in the Readme is needed, after this i will merge.

@majst01 majst01 merged commit dd67c7d into influxdata:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants