#371 Support dynamic measurement name in InfluxDBResultMapper #423
Conversation
| throwExceptionIfResultWithError(queryResult); | ||
| cacheMeasurementClass(clazz); | ||
|
|
||
| List<T> result = new LinkedList<T>(); | ||
| String measurementName = getMeasurementName(clazz); | ||
|
|
||
| if (measurementName == null || measurementName.isEmpty()) |
There was a problem hiding this comment.
Please move these verification to the top of the method. IMO Objects.requireNonNull(measurementName, "measurementName"); would be enough and the code should be resilient against an empty string.
| String measurementName = getMeasurementName(clazz); | ||
|
|
||
| if (measurementName == null || measurementName.isEmpty()) | ||
| { |
There was a problem hiding this comment.
This block { } is not compliant with the existing checkstyle.xml that you can find at the root of the project. If you have considered my previous argument as valid (Object.requireNonNull as enough), just remove this block.
| parseSeriesAs(series, clazz, result); | ||
| }); | ||
| }); | ||
| .filter(internalResult -> Objects.nonNull(internalResult) && Objects.nonNull(internalResult.getSeries())) |
There was a problem hiding this comment.
Please, do not change the indentation of lines that are not direct related with your changes. Unfortunately you will have to revert these changes.
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
============================================
+ Coverage 84.86% 84.89% +0.02%
- Complexity 270 271 +1
============================================
Files 19 19
Lines 1183 1185 +2
Branches 119 119
============================================
+ Hits 1004 1006 +2
Misses 118 118
Partials 61 61
Continue to review full report at Codecov.
|
Checkstyle not added. Please review it. Added just one single method that supports a dynamic measurement name.