Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement: use chained StringBuilder calls instead of s… #426

Merged
merged 1 commit into from
Mar 10, 2018

Conversation

majst01
Copy link
Collaborator

@majst01 majst01 commented Mar 10, 2018

…ingle calls, closes #425

@majst01 majst01 requested a review from fmachado March 10, 2018 14:32
@fmachado fmachado merged commit cc2ffe7 into master Mar 10, 2018
@codecov-io
Copy link

Codecov Report

Merging #426 into master will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #426      +/-   ##
============================================
+ Coverage     84.86%   85.03%   +0.16%     
  Complexity      270      270              
============================================
  Files            19       19              
  Lines          1183     1183              
  Branches        119      119              
============================================
+ Hits           1004     1006       +2     
+ Misses          118      116       -2     
  Partials         61       61
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/dto/BatchPoints.java 69.04% <0%> (ø) 20 <0> (ø) ⬇️
src/main/java/org/influxdb/impl/InfluxDBImpl.java 85.66% <0%> (+0.65%) 61% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d610fc...8297494. Read the comment docs.

@majst01 majst01 deleted the chainedstringbuilder branch March 10, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion : continuous calls of StringBuilder.append
3 participants