Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code which checks for unsupported influxdb versions #474

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

majst01
Copy link
Collaborator

@majst01 majst01 commented Jul 23, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #474 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #474      +/-   ##
============================================
+ Coverage      86.8%   86.91%   +0.11%     
+ Complexity      304      303       -1     
============================================
  Files            20       20              
  Lines          1296     1292       -4     
  Branches        135      134       -1     
============================================
- Hits           1125     1123       -2     
- Misses          110      111       +1     
+ Partials         61       58       -3
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/impl/InfluxDBImpl.java 88.82% <ø> (+1.06%) 69 <0> (ø) ⬇️
src/main/java/org/influxdb/InfluxDBException.java 87.27% <0%> (-3.64%) 11% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57c09d...b1844b2. Read the comment docs.

@majst01 majst01 requested review from fmachado and lxhoan July 23, 2018 15:20
@lxhoan
Copy link
Contributor

lxhoan commented Jul 23, 2018

Hi @majst01 ,
I'd like to ask if this PR means support for versions 0.x and 1.0x are now dropped ? If so I agree that checking for them is not neccessary

@majst01
Copy link
Collaborator Author

majst01 commented Jul 23, 2018

Yes, the actual version cannot talk to version 1.0 and below because of the changed lineprotocol.

@majst01 majst01 merged commit 0aac8f0 into master Jul 23, 2018
@lxhoan lxhoan modified the milestones: 2.11, 2.12 Jul 27, 2018
@majst01 majst01 deleted the remove-unsupported-influxdb-checks branch October 21, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants