-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #445 : Unpredictable errors when OkHttpClient.Builder instance is reused #478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
===========================================
- Coverage 87.35% 87.3% -0.05%
- Complexity 357 358 +1
===========================================
Files 24 24
Lines 1495 1497 +2
Branches 164 164
===========================================
+ Hits 1306 1307 +1
- Misses 122 123 +1
Partials 67 67
Continue to review full report at Codecov.
|
} | ||
}); | ||
} | ||
System.out.println("Invoking all callableList (size()=" + callableList.size() + ")"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a big fan of having sysout in tests, are these necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed them
@@ -18,21 +36,7 @@ | |||
import org.junit.platform.runner.JUnitPlatform; | |||
import org.junit.runner.RunWith; | |||
|
|||
import java.io.IOException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted as comments, thanks
Hi @majst01 , I accidentally dropped PR #477 so create this new one
PR is now mergable, please take a look, tks