fix issue #445 : Unpredictable errors when OkHttpClient.Builder instance is reused #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
===========================================
- Coverage 87.35% 87.3% -0.05%
- Complexity 357 358 +1
===========================================
Files 24 24
Lines 1495 1497 +2
Branches 164 164
===========================================
+ Hits 1306 1307 +1
- Misses 122 123 +1
Partials 67 67
Continue to review full report at Codecov.
|
majst01
requested changes
Jul 26, 2018
| } | ||
| }); | ||
| } | ||
| System.out.println("Invoking all callableList (size()=" + callableList.size() + ")"); |
There was a problem hiding this comment.
I am not a big fan of having sysout in tests, are these necessary ?
| @@ -18,21 +36,7 @@ | |||
| import org.junit.platform.runner.JUnitPlatform; | |||
| import org.junit.runner.RunWith; | |||
|
|
|||
| import java.io.IOException; | |||
There was a problem hiding this comment.
please revert this formatting
There was a problem hiding this comment.
reverted as comments, thanks
majst01
approved these changes
Jul 27, 2018
lxhoan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @majst01 , I accidentally dropped PR #477 so create this new one
PR is now mergable, please take a look, tks