- fixing memory leak and performance #521 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmachado
suggested changes
Sep 20, 2018
| escapeKey(sb, measurement); | ||
| concatenatedTags(sb); | ||
| concatenatedFields(sb); | ||
| if (precision != null) { |
There was a problem hiding this comment.
This check is not necessary. formatedTime is already doing it.
| .computeIfAbsent(this.measurement, MeasurementStringBuilder::new) | ||
| .resetForUse(); | ||
| final StringBuilder sb = CACHED_STRINGBUILDERS.get(); | ||
| sb.setLength(0); |
There was a problem hiding this comment.
Just to be kind to the next developer who wonder why we do this here, I would add a comment explaining our intention.
| .get() | ||
| .computeIfAbsent(this.measurement, MeasurementStringBuilder::new) | ||
| .resetForUse(); | ||
| final StringBuilder sb = CACHED_STRINGBUILDERS.get(); |
There was a problem hiding this comment.
IMO declaring variables as final if they are (1) only visible inside a method and (2) not strictly required to be final only bloats the code.
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
============================================
+ Coverage 87.97% 87.98% +<.01%
Complexity 380 380
============================================
Files 25 25
Lines 1547 1531 -16
Branches 172 173 +1
============================================
- Hits 1361 1347 -14
Misses 120 120
+ Partials 66 64 -2
Continue to review full report at Codecov.
|
fmachado
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #521
ThreadLocal StringBuilder hashmap cache was replaced by simple ThreadLocal StringBuilder.