Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close OkHttpClient when closing InfluxDBImpl #571

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Close OkHttpClient when closing InfluxDBImpl #571

merged 3 commits into from
Feb 1, 2019

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Feb 1, 2019

Fixes #359 and #286.

For the test, we can either expose the client as package protected for the test classes, or we use reflection by the Test method.

The test case uses the second mechanism.

@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #571 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
+ Coverage     88.16%   88.18%   +0.01%     
  Complexity      703      703              
============================================
  Files            68       68              
  Lines          2392     2396       +4     
  Branches        247      247              
============================================
+ Hits           2109     2113       +4     
  Misses          198      198              
  Partials         85       85
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/impl/InfluxDBImpl.java 90.55% <100%> (+0.09%) 87 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffbea9...77b64bd. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Feb 1, 2019

Great catch, thanks

@majst01 majst01 merged commit 06131dc into influxdata:master Feb 1, 2019
@asashour asashour deleted the close branch February 1, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants