Fix issue of connecting to influxdb without username/password on okhttp 4.x.x

[vinh0604]

This pull request is to fix the bug mentioned in #643 by only add BasicAuthInterceptor to OkHttpClient.Builder when both username and password are not null.

[majst01]

Hi @vinh0604

thanks for this fix, i was experiencing the same when i tried to upgrade okhttp as part of my regular dependency updates. But i was to lazy to look into the root cause. So welcome !

actually all test are falling with:

[ERROR] /usr/src/mymaven/src/main/java/org/influxdb/impl/InfluxDBImpl.java:47: Using the '.*' form of import should be avoided - java.util.*. [AvoidStarImport]

this must be addressed first. I also have some small nits on the MR.

[vinh0604]

Sorry, I didn't run stylecheck before pushing. Those issues were resolved now.
Please check.

[codecov-io]

Codecov Report

Merging #644 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #644      +/-   ##
============================================
- Coverage     88.09%   88.06%   -0.03%     
  Complexity      718      718              
============================================
  Files            69       69              
  Lines          2477     2480       +3     
  Branches        262      261       -1     
============================================
+ Hits           2182     2184       +2     
  Misses          207      207              
- Partials         88       89       +1

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/org/influxdb/impl/BatchProcessor.java	98.52% <100%> (ø)	19 <0> (ø)	⬇️
src/main/java/org/influxdb/impl/InfluxDBImpl.java	82.29% <100%> (+0.12%)	82 <0> (ø)	⬇️
src/main/java/org/influxdb/dto/Query.java	65% <0%> (-2.5%)	13% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8090798...5f050c4. Read the comment docs.

[majst01]

Now all checks have passed, great. May i asked you to add a additional unit test case to ensure that the extra if statement is covered. I really appreciate your contribution !

[vinh0604]

Now all checks have passed, great. May i asked you to add a additional unit test case to ensure that the extra if statement is covered. I really appreciate your contribution !

Thanks, I added one more test case in InfluxDBFactoryTest as well as removing the if condition in the internal construct of InfluxDBImpl that is only used in test.

[majst01]

Thanks for contributing.