Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generic POJO super classes #980

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

eranl
Copy link
Contributor

@eranl eranl commented Dec 5, 2023

Also, simplify type checking.

Should I add this to the manual?

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e93949f) 60.98% compared to head (66f3075) 61.05%.
Report is 1 commits behind head on master.

❗ Current head 66f3075 differs from pull request most recent head 2394d26. Consider uploading reports for the commit 2394d26 to get more accurate results

Files Patch % Lines
...n/java/org/influxdb/impl/InfluxDBResultMapper.java 90.74% 3 Missing and 2 partials ⚠️
src/main/java/org/influxdb/impl/TypeMapper.java 75.00% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #980      +/-   ##
============================================
+ Coverage     60.98%   61.05%   +0.07%     
- Complexity      435      437       +2     
============================================
  Files            70       71       +1     
  Lines          2568     2583      +15     
  Branches        276      278       +2     
============================================
+ Hits           1566     1577      +11     
- Misses          932      933       +1     
- Partials         70       73       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@majst01
Copy link
Collaborator

majst01 commented Dec 6, 2023

Support for Generics is for sure worth mentioning in the manual.

@eranl
Copy link
Contributor Author

eranl commented Dec 12, 2023

Support for Generics is for sure worth mentioning in the manual.

Done

@majst01 majst01 merged commit 4b4dc44 into influxdata:master Dec 13, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants