Skip to content

Commit

Permalink
Fix Dropdown Overlapping Dot & Text (#13585)
Browse files Browse the repository at this point in the history
* Only remove item padding when mode is action list and no selectedID is passed in

* Updoot
  • Loading branch information
alexpaxton authored Apr 23, 2019
1 parent e063e8f commit 17caffe
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
1. [13560](https://github.com/influxdata/influxdb/pull/13560): Add option to generate all access token in tokens tab

### Bug Fixes
1. [13585](https://github.com/influxdata/influxdb/pull/13585): Prevent overlapping text and dot in time range dropdown

### UI Improvements
1. [13424](https://github.com/influxdata/influxdb/pull/13424): Add general polish and empty states to Create Dashboard from Template overlay
Expand Down
4 changes: 3 additions & 1 deletion ui/src/clockface/components/dropdowns/Dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ class Dropdown extends Component<Props, State> {
customClass,
mode,
wrapMenuText,
selectedID,
} = this.props

return classnames(
Expand All @@ -127,7 +128,8 @@ class Dropdown extends Component<Props, State> {
'dropdown-wrap': wrapMenuText,
'dropdown-truncate': !wrapMenuText,
[customClass]: customClass,
[`dropdown--${mode}`]: mode,
'dropdown--radio': mode === DropdownMode.Radio,
'dropdown--action': mode === DropdownMode.ActionList && !selectedID,
}
)
}
Expand Down

0 comments on commit 17caffe

Please sign in to comment.