Skip to content

Commit

Permalink
fix(tsdb): Disable series id set cache size by default.
Browse files Browse the repository at this point in the history
This commit changes `DefaultSeriesIDSetCacheSize` to zero so that the
tag value cache is disabled by default. There is a rare known bug where
the cache can cause a segfault which crasheds the process. The cache
is being disabled instead of removed as some users may still need the
cache for performance reasons.
  • Loading branch information
benbjohnson committed May 19, 2020
1 parent 9dae8c9 commit 9c41e12
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tsdb/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ const (
DefaultMaxIndexLogFileSize = 1 * 1024 * 1024 // 1MB

// DefaultSeriesIDSetCacheSize is the default number of series ID sets to cache in the TSI index.
DefaultSeriesIDSetCacheSize = 100
// It is disabled by default.
DefaultSeriesIDSetCacheSize = 0

// DefaultSeriesFileMaxConcurrentSnapshotCompactions is the maximum number of concurrent series
// partition snapshot compactions that can run at one time.
Expand Down

0 comments on commit 9c41e12

Please sign in to comment.