Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required '@' prefix for file paths in 'influx' CLI #17356

Closed
sanderson opened this issue Mar 19, 2020 · 7 comments · Fixed by #17595
Closed

Remove required '@' prefix for file paths in 'influx' CLI #17356

sanderson opened this issue Mar 19, 2020 · 7 comments · Fixed by #17595

Comments

@sanderson
Copy link
Contributor

sanderson commented Mar 19, 2020

Proposal:
Remove the required @ prefix when specifying file paths in the influx CLI. It breaks any shell's native tab-completion.

Desired behavior:
I want to be able to use my shell's native tab-completion to quickly type file paths when using the influx CLI.

Use case:
Ease of use.

@jsteenb2
Copy link
Contributor

toooootally agree, we should support piping everywhere as well withou the arcane - requirement

@imogenkinsman
Copy link
Contributor

As part of the story I think it's important to understand why it's designed this way and if there are any implications for changing it, because I don't have context on that right now.

@sranka
Copy link
Contributor

sranka commented Mar 26, 2020

#17398 introduces a new --file (or -f ) flag that let the user specify the file to write

@sanderson
Copy link
Contributor Author

sanderson commented Mar 26, 2020

@sranka does your PR only introduce it to the write command? This change needs to happen with all commands that accept a file as input.:

influx write
influx query
influx task create

There may be others

@sranka sranka removed a link to a pull request Mar 26, 2020
6 tasks
@sranka
Copy link
Contributor

sranka commented Mar 26, 2020

Only the write command

@kelwang
Copy link
Contributor

kelwang commented Apr 2, 2020

this is fixed by #17398

@kelwang kelwang closed this as completed Apr 2, 2020
@sanderson
Copy link
Contributor Author

@kelwang #17398 only address the write command. The query and task create commands still need to be updated with the --file flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants