feat(ui): Persist variables control bar preferences #12901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
feat/persist-variables-visibility
branch
4 times, most recently
from
c75238e to
3b3fe0f
Compare
ischolten
force-pushed
the
feat/persist-variables-visibility
branch
from
3b3fe0f to
30a704f
Compare
OfTheDelmer
approved these changes
Mar 26, 2019
| /> | ||
| {isShowingVariablesControlBar && ( | ||
| {showVariablesControls && !!dashboard && ( |
| @@ -25,7 +26,8 @@ const localState = { | |||
| duration: '15m', | |||
| }, | |||
| ], | |||
| variables: initialState(), | |||
| variables: initialVariablesState(), | |||
There was a problem hiding this comment.
would we need to worry about sensitive data in variables?
There was a problem hiding this comment.
the initial state of variables doesnt have much in it. plus this is just mocks
| queries={this.queries} | ||
| key={manualRefresh} | ||
| variables={this.variableAssignments} | ||
| <SpinnerContainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12845
Closes #12846
Briefly describe your proposed changes:
Save user preference for open or closed variables control bar in local storage.
default to open.