feat(templates): add ability to update template name inline #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
templates/rename-templates-inline
branch
2 times, most recently
from
3b0792e to
bb12ecd
Compare
mavarius
approved these changes
Mar 26, 2019
ui/src/shared/copy/notifications.ts
Outdated
| @@ -845,6 +845,16 @@ export const createTemplateFailed = (error: string): Notification => ({ | |||
| message: `Failed to export resource as template: ${error}`, | |||
| }) | |||
|
|
|||
| export const updateTemplateSucceeded = (): Notification => ({ | |||
| ...defaultSuccessNotification, | |||
| message: `Successfully update template.`, | |||
There was a problem hiding this comment.
This should probably read updated
AlirieGray
force-pushed
the
templates/rename-templates-inline
branch
5 times, most recently
from
9ab97ff to
9001e47
Compare
AlirieGray
force-pushed
the
templates/rename-templates-inline
branch
from
9001e47 to
358b065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12744
This PR creates an action and reducer for updating a template, and adds the ability to update a template's name inline with the pencil icon.