feat(nav): allow user to switch orgs from the navbar #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
switch-orgs-in-nav
branch
2 times, most recently
from
fc265c8 to
562759a
Compare
OfTheDelmer
approved these changes
Apr 4, 2019
| active: boolean | ||
| className?: string | ||
| onClick?: () => void | ||
| } | ||
|
|
||
| interface DefaultProps { |
There was a problem hiding this comment.
We could update this to the new DefaultProps pattern. If we just merge the interface with the PassedProps interface and don't specify the type for defaultProps TypeScript should be able to infer the default props.
ui/src/pageLayout/containers/Nav.tsx
Outdated
| }).name | ||
| } | ||
|
|
||
| private get accountSubItem(): JSX.Element[] { |
There was a problem hiding this comment.
Let's make this it's own function component.
ui/src/pageLayout/containers/Nav.tsx
Outdated
|
|
||
| return [ | ||
| <CloudFeatureFlag key="feature-flag"> | ||
| <NavMenu.SubItem |
There was a problem hiding this comment.
Do we want to show this if there's only one organization?
AlirieGray
force-pushed
the
switch-orgs-in-nav
branch
from
562759a to
c85327d
Compare
AlirieGray
force-pushed
the
switch-orgs-in-nav
branch
from
c85327d to
8af997e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13157
This PR adds an organizations dropdown to the Home nav bar item. From this dropdown, the user can switch organizations and will be redirected to the Home page in that organization context.
This feature is feature flagged for Cloud for now.
The
/mesubroute is also removed from the Home page because it is redundant.